-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce custom exex wal errors #11789
base: main
Are you sure you want to change the base?
feat: introduce custom exex wal errors #11789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, only some suggestions on error variants
crates/exex/exex/src/wal/error.rs
Outdated
/// Directory operation `FsPathError` | ||
#[error("directory operation error: {0}")] | ||
DirFsPath(reth_fs_util::FsPathError), | ||
/// Directory operation IO Error | ||
#[error("directory operation error: {0}")] | ||
DirIO(std::io::Error), | ||
/// File operation `FsPathError` | ||
#[error("file operation error on file with id {0}: {1}")] | ||
FileFsPath(u32, reth_fs_util::FsPathError), | ||
/// File operation IO Error | ||
#[error("file operation error on file with id {0}: {1}")] | ||
FileIO(u32, std::io::Error), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some suggestions on error variants to make them more specific
/// Directory operation `FsPathError` | |
#[error("directory operation error: {0}")] | |
DirFsPath(reth_fs_util::FsPathError), | |
/// Directory operation IO Error | |
#[error("directory operation error: {0}")] | |
DirIO(std::io::Error), | |
/// File operation `FsPathError` | |
#[error("file operation error on file with id {0}: {1}")] | |
FileFsPath(u32, reth_fs_util::FsPathError), | |
/// File operation IO Error | |
#[error("file operation error on file with id {0}: {1}")] | |
FileIO(u32, std::io::Error), | |
/// Filesystem error at the path | |
#[error(transparent)] | |
FsPathError(#[from] reth_fs_util::FsPathError), | |
/// Directory entry reading error | |
#[error("failed to get {0} directory entry: {0}")] | |
DirEntry(PathBuf, std::io::Error), | |
/// Error when reading file metadata | |
#[error("failed to get metadata for file {0}: {1}")] | |
FileMetadata(u32, std::io::Error), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
…troduce-custom-exex-wal-errors
Closes #11423